It is my understanding, based on this question that problems solved on quantum computers with oracles don’t make any statements about BQP in relation to other complexity classes.
The fallacy is in the construction of the algorithm. It uses an oracle. That oracle computes something using the function in a very specific way. So the statement is really "if we compute using this oracle, then we can prove that separation".
So how do we make statements about BQP then? Almost all quantum algorithms input some sort of oracle. Grover’s algorithm inputs an oracle $U |x \rangle = (-1)^{f(x)} |x\rangle$. Shor’s algorithm inputs $U |y \rangle = |ay \; mod \; N\rangle$.
Does this mean that factoring isn’t actually in BQP (or functionBQP) as we know? If so, how could we prove or disprove this claim.